feat(amazonq): removing scroll bar and adding text wrapper for commands #7143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ctlai95
reviewed
Apr 23, 2025
| margin: 0; | ||
| padding: 0; | ||
| --mynah-font-family: var(--vscode-font-family), system-ui, -apple-system, BlinkMacSystemFont, 'Segoe UI', |
Contributor
There was a problem hiding this comment.
can we move these to a dedicated css file?
Contributor
Author
There was a problem hiding this comment.
Yes we can do that. Maybe it chat_webview.css?
Contributor
There was a problem hiding this comment.
You'll probably have to follow: https://github.com/aws/aws-toolkit-vscode/blob/master/packages/core/src/amazonq/webview/generators/webViewContent.ts#L73 and allowlist the css in the webview that should be a good resource though if you haven't seen it yet
Contributor
Author
There was a problem hiding this comment.
Can I add a TODO and come back to it later?
ctlai95
reviewed
Apr 24, 2025
packages/amazonq/.changes/next-release/Feature-89cee35a-a2c0-4b10-b492-4e9c5b4d904b.json
Outdated
Show resolved
Hide resolved
|
ctlai95
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When the command is long, customers need to scroll right for more contents, which is inconvenient.
Solution
Removing scroll bar and adding text wrapper for commands. Also copying all custom styles from https://github.com/atonaamz/aws-toolkit-vscode/blob/feature/agentic-chat/packages/core/resources/css/amazonq-webview.css.
Before and after the change:
feature/xbranches will not be squash-merged at release time.